Skip to content

fix: Check for no microseconds in timestamp for pubsub message handler #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

koenmtb1
Copy link

Fixes #160

Copy link

google-cla bot commented Feb 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@koenmtb1
Copy link
Author

I've verified this to work locally by overwriting the _message_handler with this version. It no longer throws any errors and because I had retries turned on it properly started processing any event that had this issue.

@exaby73
Copy link
Contributor

exaby73 commented Feb 16, 2024

@koenmtb1 could you add tests for this?

@inlined
Copy link
Member

inlined commented Feb 20, 2024

Additionally, please fix the formatting errors

@inlined
Copy link
Member

inlined commented Feb 20, 2024

Also, Google servers don't typically send microseconds that I'm aware of. Are you seeing problems in production or in the emulator?

@dblake10
Copy link

dblake10 commented May 1, 2024

@inlined - Having encountered this error today, I can confirm that I'm seeing problems with this in production.
@koenmtb1 - Following up on the testing and formatting requests above (from 9 to 10 weeks ago). It would be nice to get this merged so that others don't encounter this same issue.

@exaby73
Copy link
Contributor

exaby73 commented May 15, 2024

Closing in favor of #204

@exaby73 exaby73 closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sporadic datetime parse error
4 participants